BUG FIX: Fix test_bounce_animation - Githubissues

manrajgrover / halo

💫 Beautiful spinners for terminal, IPython and Jupyter

MIT License

2.89k stars 147 forks source link

BUG FIX: Fix test_bounce_animation #99

Closed eoinnoble closed 5 years ago

eoinnoble commented 5 years ago

Description of new feature, or changes

When I ran my initial tox the test_bounce_animation test was failing for me because it seemed to assume that my console would be 80 characters wide, which it was not. I used your existing get_terminal_columns function to remove the assumption, and now the test should pass regardless of the width of the tester's console.

I also fixed a typo.

Checklist

[x] Your branch is up-to-date with the base branch
[x] You've included at least one test if this is a new feature
[x] All tests are passing (I was only able to run the py36 tests)

Related Issues and Discussions

This fixes an issue raised in #78.

People to notify

@manrajgrover @otivvormes

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 286

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.6%) to 92.157%

Totals
Change from base Build 285:	0.6%
Covered Lines:	272
Relevant Lines:	289

💛 - Coveralls

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 286

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.6%) to 92.157%

Totals
Change from base Build 285:	0.6%
Covered Lines:	272
Relevant Lines:	289

💛 - Coveralls

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 286

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.6%) to 92.157%

Totals
Change from base Build 285:	0.6%
Covered Lines:	272
Relevant Lines:	289

💛 - Coveralls