mansellan / clickonce

ClickOnce packager
Other
26 stars 7 forks source link

Implement workaround for strong-named .Net Core assemblies #27

Open mansellan opened 4 years ago

mansellan commented 4 years ago

ClickOnce seems to have a problem verifying the identity of strong-named .Net Core assemblies, which can cause application validation to fail at install time. A workaround is to add such assemblies as files, rather than assemblies. This causes MSBuild to emit warnings when creating the application manifest, but these seem to be harmless.

This workaround currently requires manual intervention, but could be automated:

For all assemblies;

  1. Identify whether it is .Net Core, if so
  2. Check whether strong-named, if so
  3. Add as a file rather than an assembly, with an appropriate log message.

Undecided whether or not the resultant MSBuild warnings should be filtered from the log (perhaps show them only on Verbose logging?)