mansellan / clickonce

ClickOnce packager
Other
26 stars 7 forks source link

Entry point Parameter under Application File Section in Gui eats 6 chars in the begining of the value #39

Open Baban42 opened 3 years ago

Baban42 commented 3 years ago

If I just put entrypoint in the gui interface to : StockSys.Client.App.exe Then in the command line i get and error, and when i check what was passed along to the command line i find out that it is: --entryPoint ockSys.Client.App.exe

So in reality i have to type the first 6 chars twice to fix this issue, i dont think that is how you intended this to work ?

Here you see the value i am typing in: image

And then it runs fine.

mansellan commented 3 years ago

Thanks for reporting this, that's pretty strange - I use that param in some of my release pipelines and haven't noticed the behavior. I'll take a look. Would you be able to post the yaml from the step please? (feel free to redact any proprietary info before posting).

Baban42 commented 3 years ago

Sure, are you thinking something along these lines ? The rest of the log is just what packages it gennerates and that it succeds. But mind you that this is with the Entry point = "Shg.StShg.StockSys.Client.App.exe" And in the log it becomes Entry point = "Shg.StockSys.Client.App.exe"

Thanks for the help btw. :)

Starting: ClickOnce Packaging step

Task : ClickOnce Packager Description : Create and update ClickOnce packages Version : 1.1.1 Author : Andrew Mansell Help : More Information

D:\~\ClickOnce.exe create --source D:\~\a\build --target D:\~\a\ClickOnce --deploymentUrl \\~\ --product \App\Shg.StockSys.Client.App --version 2.0.0.1278 --publisher "Baban Ketabi" --targetFramework net48 --deploymentPage publish.htm --entryPoint Shg.StockSys.Client.App.exe ClickOnce packager Copyright 2020 Andrew Mansell See license text for details (MIT)

Creating ClickOnce package from source directory 'D:\Agent2_work\73\a\build'

Validating project... done.

Adding entry point... D:\Agent2_work\73\a\build\Shg.StockSys.Client.App.exe

Adding icon file... none found.

mansellan commented 3 years ago

I've had a look at the source code, and still can't quite see how this can be happening. The entryPoint parameter goes through the getPath function, and can potentially can have leading characters sliced off at this line. However, that's there to convert an absolute path to a relative one - if the source was "D:\build" and the entrypoint was "D:\build\myapp.exe", the function should return "myapp.exe". That doesn't seem to fit the bill here.

I'd be able to look further if I can get the actual yaml seen by ADO. If you edit the pipeline and select the ClickOnce task, there should be a link at the top of the editor to "View YAML" - these are the (non-default) values actually seen by the task. Do feel free to redact any entries you don't want to publicly disclose.

Baban42 commented 3 years ago

Here is the YAML, sorry for the inconvinence

steps: