Closed mansenfranzen closed 7 months ago
PR Description updated to latest commit (https://github.com/mansenfranzen/autodoc_pydantic/commit/11737b1e23102ef29758780562e1e4f62e6f0aa4)
⏱️ Estimated effort to review [1-5] | 2, because the changes are straightforward and involve version updates and dependency additions, which are generally easy to verify and do not require deep code logic understanding. |
🧪 Relevant tests | No |
🔍 Possible issues | No |
🔒 Security concerns | No |
Category | Suggestions |
Best practice |
Standardize version number formatting in the workflow file.___ **Update thesphinx_version to use a string format consistent with other version specifications in the workflow file.** [.github/workflows/tests.yml [52]](https://github.com/mansenfranzen/autodoc_pydantic/pull/261/files#diff-1db27d93186e46d3b441ece35801b244db8ee144ff1405ca27a163bfe878957fR52-R52) ```diff -sphinx_version: "73" +sphinx_version: "7.3" ``` |
Ensure compatibility and prevent potential future breaking changes by specifying a safer version range.___ **Add a version range fordefusedxml to ensure compatibility with future releases without breaking changes.** [pyproject.toml [43]](https://github.com/mansenfranzen/autodoc_pydantic/pull/261/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R43-R43) ```diff -defusedxml = { version = ">=0.7.1", optional = true } +defusedxml = { version = "^0.7.1", optional = true } ``` |
Type
enhancement, configuration changes
Description
defusedxml
as a new optional dependency inpyproject.toml
and included it in the 'test' extras.Changes walkthrough
tests.yml
Update Sphinx version in GitHub Actions CI
.github/workflows/tests.yml - Updated Sphinx version to 7.3 for Python 3.12 in CI test matrix.
tox.ini
Support Sphinx 7.3 in tox environments
tox.ini
envlist
to include Sphinx 7.3.pyproject.toml
Add defusedxml to optional dependencies and test extras
pyproject.toml
defusedxml
as an optional dependency.defusedxml
in the 'test' extras section.