Closed mansenfranzen closed 7 months ago
PR Description updated to latest commit (https://github.com/mansenfranzen/autodoc_pydantic/commit/07d80fa1b5895005fa182e1b21579b867e335d20)
⏱️ Estimated effort to review [1-5] | 1, because the PR involves a simple change in the configuration file which is straightforward to understand and verify. |
🧪 Relevant tests | No |
🔍 Possible issues | No |
🔒 Security concerns | No |
Category | Suggestions |
Possible issue |
Add missing environments to the 'scan' matrix to ensure comprehensive security scans.___ **Ensure that the 'scan' matrix includes all necessary environments. The previous matrixincluded "app", which is missing in the new configuration. If "app" is still a relevant environment for security scans, it should be added back to the matrix.** [.github/workflows/tests-scheduled.yml [38]](https://github.com/mansenfranzen/autodoc_pydantic/pull/271/files#diff-b1091a4d2ddaa8b0889fa0d54b1a03094fe4f61495118ecab03e0179e32744a0R38-R38) ```diff -scan: ["lib", "dev"] +scan: ["lib", "dev", "app"] ``` |
Type
bug_fix
Description
Changes walkthrough
tests-scheduled.yml
Update Tox Environment Name in Scheduled Test Workflow
.github/workflows/tests-scheduled.yml
"app" to "dev".