search

mansj / enable-media-replace

***DEVELOPMENT DISCONTINUED*** Enable Media Replace, a WordPress plugin to make it possible to replace uploaded media files in a simple way.
GNU General Public License v2.0
28 stars 27 forks source link

Code Improvements #20

Closed ramiy closed 7 years ago

ramiy commented 8 years ago

Improvements:

mansj commented 8 years ago

Thank you. I'm somewhat hesitant to update the use of the english strings, since that would break all translations. Any reason for changing them?

Is there sufficient support to replace title tag with aria-label? I'm not sure.

Also, why make the warning message notice dismissable?

ramiy commented 8 years ago

@mansj

  1. Don't worry about "braking" translations. WordPress core and other plugins update the strings in each version. But each update just make it easier for translators. This change will decrease the amount of translation strings and make it even easier to translate the plugin to other languages.
  2. Replacing title attribute with aria-label is the standard. WordPress code did the same change, see changeset 35998, 36016, 36032, 36172 and in many more.
  3. Dismissable message notice is for UX, it won't remove the message entirely in all pages. The notice will be remove only when clicked, and the effect is per file and per page load. Don't have a reference, but this is the WordPress standard for notice messages.
ramiy commented 8 years ago

As for the PO/MO files, you can delete them. See the i18n changes in wp4.6.