mansona / ember-cli-notifications

⚛ Atom inspired notification messages for ember-cli
https://ember-cli-notifications.netlify.app/
MIT License
177 stars 94 forks source link

Mistake in interactive documentation page #284

Open turbcool opened 4 years ago

turbcool commented 4 years ago

There is a mistake in code on the interactive documentation page.

application.inject(injectionTarget, 'notifications', 'notification-messages:service')

'notification-messages:service' should be 'service:notifications'

jacobq commented 2 years ago

Ha, just saw this (after mentioning in #311), but you are right. In fact, now in Ember 4.x injecting like that no longer works, so I've suggested removing this part of the docs in #339