search

mansona / ember-cli-notifications

⚛ Atom inspired notification messages for ember-cli
https://ember-cli-notifications.netlify.app/
MIT License
177 stars 94 forks source link

Remove use of ember-get-config to get the current config #360

Closed francois2metz closed 1 year ago

francois2metz commented 1 year ago

We have an app with a different configuration between test and development/production. We autoclear the notification on production, but not on tests to test the content of the notification. Once we switched to embroider, we had some issues when running tests on the /tests route in the browser. The notifications started to disappear. As the addon use ember-get-config, it seems of always get the development/production config instead of the test one. So I switched to ember way to do the same.

netlify[bot] commented 1 year ago

Deploy Preview for ember-cli-notifications ready!

Name Link
Latest commit 10aa770b8d54dc1864e1c686826e40cb4da41e27
Latest deploy log https://app.netlify.com/sites/ember-cli-notifications/deploys/645b91bd57a96b00084afe94
Deploy Preview https://deploy-preview-360--ember-cli-notifications.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

mansona commented 1 year ago

I'm not too sure about making this change because it would have other effects 🤔 the issue you're having in embroider is due to be fixed in https://github.com/embroider-build/embroider/pull/1412 tho

francois2metz commented 1 year ago

Curious to know about the side effects. Good to know that it's an embroider bug.