search

mansona / ember-cli-notifications

⚛ Atom inspired notification messages for ember-cli
https://ember-cli-notifications.netlify.app/
MIT License
177 stars 94 forks source link

Update `postcss-preset-env` to avoid build warnings #361

Closed Turbo87 closed 11 months ago

Turbo87 commented 1 year ago

I've been seeing the following warning in my builds for a while:

┌─────────────────────────────────────────────────────────────────────────────────┐
│                                                                                 │
│   This version of postcss-preset-env is not optimised to work with PostCSS 8.   │
│                Please update to version 7 of PostCSS Preset Env.                │
│                                                                                 │
│                    If you find issues, you can report it at:                    │
│          https://github.com/csstools/postcss-plugins/issues/new/choose          │
│                                                                                 │
└─────────────────────────────────────────────────────────────────────────────────┘

It looks like #320 updated the version of broccoli-postcss from v5 to v6, which then updated PostCSS under the hood from v7 to v8. The postcss-preset-env dependency of this project however was not updated and was still pointing to a version that was causing the above warning.

This PR updates the dependency to the latest version, which is compatible with PostCSS v8. The changelog for the diff is available at https://github.com/csstools/postcss-plugins/blob/main/plugin-packs/postcss-preset-env/CHANGELOG.md. I did not find any breaking changes that would be relevant to this project though, so no code changes on our side were necessary.

netlify[bot] commented 1 year ago

Deploy Preview for ember-cli-notifications ready!

Name Link
Latest commit 878c91cb5431827eec7243c35d30e6a24d05477f
Latest deploy log https://app.netlify.com/sites/ember-cli-notifications/deploys/646fc44a839e34000851946f
Deploy Preview https://deploy-preview-361--ember-cli-notifications.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Turbo87 commented 1 year ago

362 should hopefully resolve the compilation issue...

Turbo87 commented 1 year ago

@mansona rebasing fixed the compilation issue :)

nlepage commented 1 year ago

Hi @mansona any chance this would be merged and released soon?