search

mansona / ember-cli-notifications

⚛ Atom inspired notification messages for ember-cli
https://ember-cli-notifications.netlify.app/
MIT License
177 stars 94 forks source link

ember-on-modifier deprecation warnings #363

Open sepuckett86 opened 1 year ago

sepuckett86 commented 1 year ago

I'm seeing these deprecation warnings while in an app on Ember 3.28 using ember-cli-notifications:

import { deprecate } from '@ember/application/deprecations';has been deprecated, please update toimport { deprecate } from '@ember/debug';` [deprecation id: old-deprecate-method-paths]

deprecate.js:117 DEPRECATION: When calling deprecate you must provide for in options. Missing options.for in "ember-on-modifier.prevent-default" deprecation [deprecation id: ember-source.deprecation-without-for]

deprecate.js:117 DEPRECATION: When calling deprecate you must provide since in options. Missing options.since in "ember-on-modifier.prevent-default" deprecation [deprecation id: ember-source.deprecation-without-since]

DEPRECATION: (prevent-default) has been moved to ember-event-helpers. [deprecation id: ember-on-modifier.prevent-default] See https://github.com/buschtoens/ember-event-helpers for more details.

npm ls ember-on-modifier shows these warnings are linked to ember-cli-notifications:

└─┬ ember-cli-notifications@8.0.0 └── ember-on-modifier@1.0.1

If I remove ember-cli-notifications from the app, these warnings go away. If I update Ember to 4.0, these are breaking failures.

Thanks for your time, any fixes would be much appreciated