Closed GoogleCodeExporter closed 9 years ago
That's a nice patch. I'm just a little worried about the option name :)
Do you agree for this renaming :
* add_keyboard_to_root_window -> keyboard_use_root
* place_keyboard_by_control -> keyboard_place_near_control
For initial rotation, it's really specific for you, i will search how to
generalize
it (because get_initial_keyboard_rotation_from wait for an object... maybe it
would
be better to have a keyboard_arguments or something like that...)
Original comment by txprog
on 7 Apr 2010 at 3:43
Original comment by txprog
on 7 Apr 2010 at 3:43
I think the way I've done it with really long names is a bit clunky. I think
renaming
them is good. These changes were quite specific to me but I'm sure someone else
might
use them. I'm not sure of the tidiest way to do this as I'm quite new to PyMT
and to
python too.
Original comment by jaybradl...@gmail.com
on 7 Apr 2010 at 3:47
Original comment by txprog
on 1 Jun 2010 at 8:43
Original comment by txprog
on 8 Jun 2010 at 12:15
Jay,
I've included the "add to root window" patch, thanks for that.
About the pos/rot: I'm not sure.
a) Both are kwargs for the keyboard, so if we want that adjustable we might
just as well provide a keyboard_kwargs param for textinput.
b) You can create your own MTVKeyBoard with your own params and pass it to
textinput.
c) You can, after creating the textinput object, access the keyboard via
my_textinput_object.keyboard and if you want adjust the parameters yourself.
Since the calculations in the patch are pretty specific for your case, I'd
rather not include it since other's might want other behaviour. I'd just make
setting these params the caller's responsibility.
What do you think?
Original comment by dennd...@gmail.com
on 15 Jun 2010 at 9:33
I think you're correct. The best thing to do would be to access the keyboard
after creating the text input and adjust it then using
my_textinput_object.keyboard. Thanks for adding the "add to root window" bit in
though. I'd consider this issue done now.
Original comment by jaybradl...@gmail.com
on 15 Jun 2010 at 9:50
OK, you can find it in the latest master.
Here is the link to the commit:
http://github.com/tito/pymt/commit/9c5e8791caf7e23bc8caf6b5d070dae88a41cff2
Thanks. (We're missing you on IRC! :-)
Original comment by dennd...@gmail.com
on 15 Jun 2010 at 9:57
Original issue reported on code.google.com by
jaybradl...@gmail.com
on 7 Apr 2010 at 2:19Attachments: