mansueto-institute / cloudtile

Converting geospatial file formats to vectortile files
GNU General Public License v3.0
2 stars 2 forks source link

fix: ECS args #37

Closed manmartgarc closed 1 year ago

manmartgarc commented 1 year ago

Description

Introducing the --tc-kwargs functionality from #34 had a bug when no settings were passed. This mean that even though the CLI was working locally, when it came to sending the CLI args to the ECS container was wrong. This PR fixes that issue and extends unit tests to check for this case.

Type of change

How Has This Been Tested?

Extended unit tests within tests/test_ecs.py

Checklist

github-actions[bot] commented 1 year ago

Coverage

Coverage Report
FileStmtsMissCoverMissing
/opt/hostedtoolcache/Python/3.11.2/x64/lib/python3.11/site-packages/cloudtile
   __init__.py00100% 
   __main__.py60100% 
   converter.py570100% 
   ecs.py780100% 
   geofile.py1250100% 
   s3.py970100% 
   tippecanoe.py680100% 
/opt/hostedtoolcache/Python/3.11.2/x64/lib/python3.11/site-packages/cloudtile/cli
   __init__.py560100% 
   parsers.py720100% 
TOTAL5590100% 

Tests Skipped Failures Errors Time
135 0 :zzz: 0 :x: 0 :fire: 7.158s :stopwatch: