docker

[vonProteus]

The idea

can you add creating of docker image (x64 arm and arm64) to your build ci?

Why this feature should be added to the app ?

docker is convenient and it would god start for k8s jobs

[vonProteus]

something like this would be sufficient https://github.com/vonProteus/mangadex-downloader-docker https://hub.docker.com/r/vonproteus/mangadex-downloader-docker and i would like to switch to official image when it will be available

[mansuf]

Yes, i will add it to my build CI soon and i will use your docker image as a reference, thank you for this !

[mansuf]

Docker image added in https://hub.docker.com/r/mansuf/mangadex-downloader, tag latest (v2.10.3)

[mansuf]

About the increased size docker image, now latest tag has reduced size, but it doesn't have optional features. If you want to use optional features, you can install from latest-optional tag

Previously, it was almost 1GB (800MB - 900MB) size for a compressed docker image. And now it was 400MB

[rokibhasansagar]

@mansuf, Wouldn't it be better to use Alpine Linux for the base image of Docker? It would reduce the image size too.

[mansuf]

Wouldn't it be better to use Alpine Linux for the base image of Docker? It would reduce the image size too.

I agree, but if i want to use alpine linux as base image, then the supported OS/ARCH will be reduced too for optional tags. I tested it out myself and the results is the image only support for amd64 and arm64. The arm/v7 doesn't included (because it throws error when installing rust compiler, saying it doesn't have binaries for that cpu architecture).

I guess i can use alpine linux as base image for non-optional tags, but other than that i think i will keep debian as base image.

[mansuf]

Base image for non-optional tags are now using alpine linux https://github.com/mansuf/mangadex-downloader/commit/71b4697cdb4bb1d607f71d1cbcc9b7eeb2772857 https://github.com/mansuf/mangadex-downloader/commit/ff679924096d6d0a76e16d25b6842ba134c471f4