Feature/chapter naming format

mansuf / mangadex-downloader

A command-line tool to download manga from MangaDex, written in Python.

https://mangadex-dl.mansuf.link/

MIT License

472 stars 37 forks source link

Feature/chapter naming format #114

Closed Gadzek closed 1 month ago

Gadzek commented 1 month ago

Added --chapter-naming-format argument with simple syntax to allow specifying downloaded chapter naming pattern.

For example: "--chapter-naming-format" "{{M}} Vol {{V:2}} Ch. {{C:3}} - {{T}} [{{G}}]" will produce filenames with following pattern: Ijiranaide, Nagatoro-san Vol 11 Ch. 080 - ...If You Win Even a Single Match, Senpai [anonymous]

mansuf commented 1 month ago

I appreciate your effort in this PR, but uhhhhhh, this feature is already exist in v3.0.0 development (Commits: https://github.com/mansuf/mangadex-downloader/commit/144c8b5106aa60af3e4c0f163a1c43d0da1aa3f7 https://github.com/mansuf/mangadex-downloader/commit/46d8f083de55e452bac916616e5e838b04728bdd https://github.com/mansuf/mangadex-downloader/commit/3e257fb5264c6e46ecb23ac1e45eb8f269d257f1 https://github.com/mansuf/mangadex-downloader/commit/3698cf10aa22c14e1225000bffbff4f2a3b55c2e). You can see the documentation in here

I'm really sorry you didn't know about this, because it's on separated branch, not in main branch.

Gadzek commented 1 month ago

Nah, it's ok, I wrote this for personal use like a year ago and just wanted to check if it would be useful. Although I must have missed it while reading the v3.0.0 to-do list.