Closed tommai78101 closed 3 weeks ago
I don't mean that the user can only do 10 items per page due to MangaDex restrictions, but rather, have the app query for the pages first, then output the list altogether after the querying is done.
Actually the limit 10 items per page is nothing to do with MangaDex restrictions. I just set it so users can see from 1 to 10 fitting in the console screen without scrolling to top. If you're wondering, the app doesn't query items per 10 to MangaDex API, it's usually hundreds (100 or 500 maximum) items.
Luckily, implementing this isn't hard and time consuming. It should get done today. I will working on it
Thank you! I'm pleasantly surprised and happy.
This feature has been added in commit https://github.com/mansuf/mangadex-downloader/commit/e7e58653649c803f8961ce4a9a7e1541a62e7837. You can test it by installing development version.
NOTE: You're about installing a major update (v3.0.0), so there will be any breaking changes. Currently, there is no migration guide (coming soon). So i suggest to try it out before starting download any manga
Installation with Git & Pip:
pip uninstall mangadex-downloader
pip install -U git+https://github.com/mansuf/mangadex-downloader.git@e7e58653649c803f8961ce4a9a7e1541a62e7837
Installation from Github Artifact CI (bundled executable):
You can download it from here in "artifacts" section
Usage
mangadex-dl "library" --login --page-size 50
If you have problem or bugs, let me know 👍. Also thank you for the idea !
Thank you again. If I encounter any problems, I'll just file a new issue instead. Easier to keep track of.
The idea
Currently, when we do
mangadex-dl "library" --login
, we can list out the manga series in a list up to 10 items per page:Can we let the user specify what page size the user wants to see? Like this example:
mangadex-dl "library" --login --pageSize 50
where N is 50I don't mean that the user can only do 10 items per page due to MangaDex restrictions, but rather, have the app query for the pages first, then output the list altogether after the querying is done.
Like, if the user wants to see 50 items per page, let the app query for the first 50 items by querying 10 items per page 5 times in total, then collect all 50 items together in a list, then output all 50 items when it finishes collecting them. If the user has less than 50, the app will query up to the last item, collect all items into a list, and then output those items when it is done.
Something like that would be really nice to have.
Why this feature should be added to the app ?
Currently, there is no built-in feature where the app can only list out the manga titles saved to the user's library or list in full.
You have to navigate per page with
next
orprevious
to get up to 10 items per page. Ideally, I would like for it to be able to list all titles in 1 page, but only after interrogating MangaDex API a couple of times first, before listing them all out in 1 go.