search

mantas-done / subtitles

Subtitle/caption converter
https://gotranscript.com/subtitle-converter
MIT License
142 stars 48 forks source link

\n -> \r\n reason question #21

Closed osavchenko closed 4 years ago

osavchenko commented 5 years ago

Hello! Any reason to change \n to \r\n line endings?

kminek commented 4 years ago

@osavchenko i also noticed this. looks like a bug to me. converter should keep input file line-endings - if it gets LF it outputs LF, if it gets CRLF -> CRLF.

mantas-done commented 4 years ago

I think it was for Travis unit test support.

But I don't know which one is better. If somebody needs a certain line endings, I can add an option which line ending to output. ->endings("\n") or ->endings("\r\n")

But probably it doesn't matter which endings are used.