mantas-done / subtitles

Subtitle/caption converter
https://gotranscript.com/subtitle-converter
MIT License
142 stars 48 forks source link

DFXP files on Netflix seem to use new timing format #42

Closed yanosh-k closed 1 year ago

yanosh-k commented 2 years ago

Description:

It looks like Netflix changed the format for the begin and end attributes of the .DFXP subtitles. The subtitles used to work with the following:

...
<p begin="00:00:34,040" end="00:00:35,500">[men shouting indistinctly]</p>
<p begin="00:00:42,375" end="00:00:43,625">[horse neighs]</p>
....

now they only work with the following:

....
<p begin="340400000t" end="355000000t">[men shouting indistinctly]</p>
<p begin="423750000t" end="436250000t">[horse neighs]</p>
...

The time in the new attributes is 10000000 * seconds and has t appended to it.

Here is a copy of an original subtitles file downloaded from Netflix: N9no1KQV.zip

Environment:

This has been tested with latest release (v0.3.10), converting the following file: The.King.2019.720p.NF.WEB-DL.DDP5.1.x264-NTG-HI.zip to .DFXP DFXPThe.King.2019.720p.NF.WEB-DL.DDP5.1.x264-NTG-HI.zip, for the following movie: https://www.netflix.com/watch/80182016 (The King - 2019).

Steps to Reproduce: ================

  1. Convert The.King.2019.720p.NF.WEB-DL.DDP5.1.x264-NTG-HI.srt to .DFXP
  2. Open the https://www.netflix.com/watch/80182016 movie.
  3. Press CTRL+SHIFT+ALT+T, while playing
  4. Choose the converted .DFXP file

Expected result:

The subtitles are shown on the screen, when there is a dialog in the movie.

Actual Result:

No subtitles are shown on the screen.

mantas-done commented 1 year ago

Wow, nice description of the problem. Thank you. Fixed.