mantasjasikenas / flow-launcher-shortcuts-plugin

A powerful Flow Launcher plugin for quickly opening users defined shortcuts.
34 stars 2 forks source link

Feature Request: Pull URL Icons/define custom path for Icons #33

Closed c0deZ3R0 closed 1 week ago

c0deZ3R0 commented 2 weeks ago

Would love for the URL icons to also be displayed:

20240919_chrome

I assume it’s a lower priority, but it might be simpler to specify a path for .ico files, like this:

[
{
    "Type": "IconDirectory",
    "Directory" : "C:/icons/"
},
{
    "Type": "Url",
    "Url": "calculator:///",
    "Key": "calculator",
}
]

Icons labelled with the corresponding key, such as C:/icons/calculator.ico, could override the default.

Thanks for the updates! This plugin has made my life so much easier!

mantasjasikenas commented 1 week ago

Thank you for your feature request and feedback!

I’m considering adding a field in the Flow Launcher settings where users can specify a directory for icons, similar to how shortcuts and variables can currently be set. Would that solution work for you? I could also include a command to set the folder directly. Let me know what you think!

c0deZ3R0 commented 1 week ago

Personally, I believe a single folder with icons, each directly associated with the relevant key, would be sufficient. I don’t see much value in using multiple directories; even a default directory within the plugin could work just fine.

That said, others may have different perspectives.

I’ve taken a look through your codebase and was thinking of submitting a pull request for this change. If you're open to it, please let me know how you'd like to proceed, and I’d be happy to give it a try.