search

mantaskaveckas / react-siema

ReactSiema Demo
https://kaveckas.github.io/react-siema/
89 stars 39 forks source link

Error fix + API update (backwards compatible) #17

Closed denkwai closed 6 years ago

denkwai commented 6 years ago
  1. Fixed removeEventListener error on componentWillUnmount
  2. Updated prev and next API methods to correspond current Siema API – accept 2 optional parameters: number of slides to scroll (optional, default is 1) and a callback function (optional)
juntaod commented 5 years ago

I didn't see a published NPM version with this fix and hit the exact issue in componentWillUnmount, could you update the npm version so we can get a fix from that? Thanks.

juntaod commented 5 years ago

@mantaskaveckas