search

manticoresoftware / manticoresearch-backup

Repository for Manticore Search backup scripts
GNU General Public License v3.0
3 stars 1 forks source link

Store config name in meta file on backup and use it on restore #117

Open donhardman opened 2 months ago

donhardman commented 2 months ago

Currently, we are only storing versions when we perform a backup.

However, there is an issue with hardcoded values that we should aim to remove: https://github.com/manticoresoftware/manticoresearch-backup/blob/fa1fecdf149e60248b47e1acfe64cf23d9c83fee/src/Lib/ManticoreBackup.php#L260-L263

To resolve this, we should store meta information and also write the config name during the backup stage, and restore it accordingly. To simplify things, it seems the best idea is to use a single metafile instead of versions and other elements.

This is a breaking change and will make old backups incompatible with the new tool due to changes in the system file name we will use for storing metadata.

sanikolaev commented 2 months ago

This is a breaking change and will make old backups incompatible

I think we can make it non-breaking by just supporting the way it works now.