manticoresoftware / manticoresearch-buddy

Manticore Buddy is a Manticore Search's sidecar which helps it with various tasks
GNU General Public License v3.0
20 stars 2 forks source link

DROP sharded table #266

Open donhardman opened 4 months ago

donhardman commented 4 months ago

We should add functionality to support dropping shared tables. The command should clean up everything associated with the shared table. To make this happen, we should start with a special command DROP SHARDED TABLE. After that, we'll migrate to use the DROP TABLE command, while the daemon should detect if it's a shared table or not and process the request accordingly.

This requires modifications on the daemon side, so we'll start with the DROP SHARDED TABLE syntax first.

donhardman commented 1 day ago

It was implemented in these two pull requests:

During the implementation of the DROP SHARDED TABLE logic, a requirement also arose to refactor our old system with hooks. As a result, I made changes in the core and placed code in the appropriate locations. The QueryProcessor is now much cleaner, and the common logic for using processors of each plugin has become clearer.