search

manticoresoftware / manticoresearch-buddy

Manticore Buddy is a Manticore Search's sidecar which helps it with various tasks
GNU General Public License v3.0
20 stars 2 forks source link

Check min_infix_len before we do fuzzy/autocomplete logic #330

Closed donhardman closed 1 day ago

donhardman commented 1 month ago

We should validate if the table we interact with has min_infix_len enabled. If not, we should show an error since it won't work anyway.

We should try to cache this response (successful ones only; if there's no min_infix_len, we shouldn't cache). This will help us avoid extra queries every time the next autocomplete or fuzzy logic is performed.

Checklist:

To be completed by the assignee. Check off tasks that have been completed or are not applicable.

- [x] Task estimated - [x] Specification created, reviewed and approved - [x] Implementation completed - [x] Tests developed - [x] Documentation updated - [x] Documentation proofread - [x] Changelog updated - [x] OpenAPI YAML updated and issue created to rebuild clients
donhardman commented 1 month ago

Implemented special caching mechanisms in these pull requests:

sanikolaev commented 1 month ago

Let's mention this in the docs - https://github.com/manticoresoftware/manticoresearch/pull/2442

donhardman commented 1 month ago

The docs have been updated and are now awaiting review.

donhardman commented 1 month ago

Closing as it was merged: https://github.com/manticoresoftware/manticoresearch-buddy/pull/332

sanikolaev commented 3 weeks ago

Reopening to make sure it's covered by a test.

@PavelShilin89 pls take a look.

PavelShilin89 commented 6 days ago

Done in https://github.com/manticoresoftware/manticoresearch/pull/2550