manticoresoftware / manticoresearch-buddy

Manticore Buddy is a Manticore Search's sidecar which helps it with various tasks
GNU General Public License v3.0
20 stars 2 forks source link

The replace plugin doesn't work in the replication cluster #359

Closed djklim87 closed 4 weeks ago

djklim87 commented 1 month ago

Bug Description:

select * from c:t
--------------

+------+------+------+
| id   | f    | f2   |
+------+------+------+
|    1 | a    | b    |
+------+------+------+
1 row in set (0.00 sec)
--- 1 out of 1 results in 0ms ---

mysql> replace into c:t set f2='c' where id=1;
--------------
replace into c:t set f2='c' where id=1
--------------

ERROR 1064 (42000): P01: syntax error, unexpected $undefined near '`c:t` (id,f,f2) VALUES (1,'a','c')'

Generaly replace command in cluster works fine

mysql> replace into c:t values(1, 'a', 'c');
--------------
replace into c:t values(1, 'a', 'c')
--------------

Query OK, 1 row affected (0.00 sec)

Manticore Search Version:

6.3.7

Operating System Version:

docker

Have you tried the latest development version?

Yes

Internal Checklist:

To be completed by the assignee. Check off tasks that have been completed or are not applicable.

- [x] Implementation completed - [x] Tests developed - [x] Documentation updated - [x] Documentation reviewed - [x] Changelog updated
djklim87 commented 1 month ago

Waiting for review https://github.com/manticoresoftware/manticoresearch-buddy/pull/361

djklim87 commented 1 month ago

Docs https://github.com/manticoresoftware/manticoresearch/pull/2596

sanikolaev commented 1 month ago

Waiting for review https://github.com/manticoresoftware/manticoresearch-buddy/pull/361

Reviewed. Merged.

sanikolaev commented 1 month ago

Merged updating deps.txt in the main repo and the docs PR

@PavelShilin89 pls update your tests on _update, so they cover the cluster:table case.

PavelShilin89 commented 1 month ago

Testing performed in PR - https://github.com/manticoresoftware/manticoresearch/pull/2648

sanikolaev commented 4 weeks ago

@djklim87 pls update the changelog

djklim87 commented 4 weeks ago

Done