Switch to manticoresoftware/php-code-standard coding standard

manticoresoftware / manticoresearch-php

Official PHP client for Manticore Search

MIT License

167 stars 32 forks source link

Closed aivchen closed 8 months ago

aivchen commented 11 months ago

Switch from PSR-2 to PSR-12. Fixes #137.

sanikolaev commented 11 months ago

@aivchen in https://github.com/manticoresoftware/manticoresearch-php/issues/137#issuecomment-1798207734 we agreed to adopt https://github.com/manticoresoftware/php-code-standard instead, which is more complex than just PSR-12. Would you like to look into it to possibly remake your changes accordingly, so they comply with the adopted standards?

aivchen commented 11 months ago

Sure! I'll do my best.

aivchen commented 10 months ago

Done. But I excluded some rules from the config:

vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/TypeHints/DeclareStrictTypesSniff.php - it breaks the code
SlevomatCodingStandard.Complexity.Cognitive - this rule is available only in slevomat/coding-standard:>=8.0. But that package requires php >= 7.2 while our minimal requirement is PHP 7.1. So I had to install slevomat/coding-standard:^7.0

Nick-S-2018 commented 8 months ago

After resolving the conflicts that appeared due to later commits, it's done via https://github.com/manticoresoftware/manticoresearch-php/pull/189