manticoresoftware / manticoresearch-php

Official PHP client for Manticore Search
MIT License
167 stars 32 forks source link

This PR adds a method to delete multiple documents by IDs #171

Closed markomilivojevic closed 10 months ago

markomilivojevic commented 10 months ago

@Nick-S-2018 it's great that you requested a docs update.

Now I noticed some inconsistency in the response while deleting multiple documents by ID.

Shouldn't the response be compatible with the one that deletes multiple documents by query? I.e.:

{"_index": "test", "deleted": 1} - where deleted is the number of deleted documents.

Reference: https://github.com/manticoresoftware/manticoresearch/issues/1582 @sanikolaev

Nick-S-2018 commented 10 months ago

@markomilivojevic This difference is basically caused by our wish to keep compatibility with Elasticsearch formats to make it familiar for the Elastic users.