manticoresoftware / manticoresearch

Easy to use open source fast database for search | Good alternative to Elasticsearch now | Drop-in replacement for E in the ELK soon
https://manticoresearch.com
GNU General Public License v3.0
8.67k stars 483 forks source link

Forbid setting incorrect values for numeric fields #2312

Open Nick-S-2018 opened 3 weeks ago

Nick-S-2018 commented 3 weeks ago

Bug Description:

Now we convert incorrect values of numeric data types ( e.g., "a" or "" for the bigint field) , to 0. Instead, we should forbid such conversion and throw an appropriate error. But if a value can be correctly converted to number (e.g. "123") , conversion still must be done.

Alternatively, we could introduce some kind of option enabling/disabling such strict conversion which the user would be able to use to get more flexible behavior

Manticore Search Version:

Manticore 6.3.1 9bd02672d@24061008 dev

Operating System Version:

Ununtu 22.04 LTS

Have you tried the latest development version?

Yes

Internal Checklist:

To be completed by the assignee. Check off tasks that have been completed or are not applicable.

- [ ] Implementation completed - [ ] Tests developed - [ ] Documentation updated - [ ] Documentation reviewed - [ ] Changelog updated
Nick-S-2018 commented 3 weeks ago

Related to https://github.com/manticoresoftware/manticoresearch-python/issues/17

sanikolaev commented 2 weeks ago

@Nick-S-2018 pls improve the spec, e.g.:

Nick-S-2018 commented 6 days ago

I've updated the description to cover these details

sanikolaev commented 5 days ago

@Nick-S-2018 does this issue block anything?

Nick-S-2018 commented 5 days ago

No, it's not a blocker.