manticoresoftware / manticoresearch

Easy to use open source fast database for search | Good alternative to Elasticsearch now | Drop-in replacement for E in the ELK soon
https://manticoresearch.com
GNU General Public License v3.0
8.88k stars 492 forks source link

Limited number of characters #2528

Open PavelShilin89 opened 3 weeks ago

PavelShilin89 commented 3 weeks ago

We already have the option to skip loading the selected plugin when the daemon starts, but if we try to skip installing many plugins, any further conditions will be skipped when we go beyond the number of characters that can be processed. Reproducing this with spaces instead of plugins, in an attempt to go beyond the character limit I couldn't. You can reproduce it like this:

MRE:

sed -i '/data_dir = \/var\/lib\/manticore/a\    buddy_path = manticore-executor -n /usr/share/manticore/modules/manticore-buddy/src/main.php --debugv \\' /etc/manticoresearch/manticore.conf && sed -i '/buddy_path =/a\    --skip=manticoresoftware/buddy-plugin-autocomplete \\\n    --skip=manticoresoftware/buddy-plugin-fuzzy \\\n    --skip=manticoresoftware/buddy-plugin-update \\\n    --skip=manticoresoftware/buddy-plugin-sharding \\\n    --skip=manticoresoftware/buddy-plugin-queue \\\n    --skip=manticoresoftware/buddy-plugin-replace \\\n    --skip=manticoresoftware/buddy-plugin-knn \\\n    --skip=manticoresoftware/buddy-plugin-modify-table \\\n    --skip=manticoresoftware/buddy-plugin-alter-rename-table \\\n    --skip=manticoresoftware/buddy-plugin-alter-distributed-table \\\n    --skip=manticoresoftware/buddy-plugin-alter-column \\\n    --skip=manticoresoftware/buddy-plugin-test \\\n    --skip=manticoresoftware/buddy-plugin-cli-table \\\n    --skip=manticoresoftware/buddy-plugin-show \\\n    --skip=manticoresoftware/buddy-plugin-select \\\n    --skip=manticoresoftware/buddy-plugin-alias \\\n    --skip=manticoresoftware/buddy-plugin-insert \\\n    --skip=manticoresoftware/buddy-plugin-drop \\\n    --skip=manticoresoftware/buddy-plugin-create \\\n    --skip=manticoresoftware/buddy-plugin-emulate-elastic \\\n    --skip=manticoresoftware/buddy-plugin-backup \\\n    --skip=manticoresoftware/buddy-plugin-empty-string' /etc/manticoresearch/manticore.conf
cat /etc/manticoresearch/manticore.conf
searchd
mysql -h0 -P9306 -e "SHOW BUDDY PLUGINS\G;"
sanikolaev commented 3 weeks ago

It's likely the problem comes from the daemon. I've moved this issue to the daemon's repo.