manticoresoftware / manticoresearch

Easy to use open source fast database for search | Good alternative to Elasticsearch now | Drop-in replacement for E in the ELK soon
https://manticoresearch.com
GNU General Public License v3.0
9.08k stars 509 forks source link

Test: buddy protocol #2604

Open donhardman opened 1 month ago

donhardman commented 1 month ago

Proposal:

It seems that it's a good idea to cover Buddy protocol with CLT tests. To do so, we can simply send various queries to different endpoints that will be routed to Buddy and check in the log with --debugv mode that we have request data: there and it has the proper structure as follows in our declaration of protocol: https://github.com/manticoresoftware/manticoresearch-buddy?tab=readme-ov-file#communication-protocol-v2

For example, when we send a query to /sql or /sql?mode=raw, we should expect to receive an 'Unknown SQL request' message from the daemon to Buddy, along with a properly parsed body.

Related issue: https://github.com/manticoresoftware/manticoresearch/issues/2603

Checklist:

To be completed by the assignee. Check off tasks that have been completed or are not applicable.

- [ ] Implementation completed - [ ] Tests developed - [ ] Documentation updated - [ ] Documentation reviewed - [ ] [Changelog](https://docs.google.com/spreadsheets/d/1mz_3dRWKs86FjRF7EIZUziUDK_2Hvhd97G0pLpxo05s/edit?pli=1&gid=1102439133#gid=1102439133) updated - [x] OpenAPI YAML updated and issue created to rebuild clients
sanikolaev commented 1 month ago

It's important in this task to test various types of queries that get routed to Buddy:

sanikolaev commented 1 month ago

It's important in this task to test various types of queries that get routed to Buddy:

Dupe of https://github.com/manticoresoftware/manticoresearch-buddy/issues/369#issuecomment-2430993567 . May have been already done by the moment we get to this task.