search

mantidproject / autoreduce

Autoreduction service
0 stars 0 forks source link

Improve EndOfRunMonitor script and Manual Submission script in sync #324

Closed lottiegreenwood closed 7 years ago

lottiegreenwood commented 7 years ago

As far as I understand, the End of Run monitor and manual submission script should be very similar. It might be worth them having a shared module for their lookup code. In refactoring this, how they lookup data for the runs can also be changed. Eg. when looking up the RB and cycle number for a particular run, ICAT can be queried first and if that fails, more work around methods such as checking last three numbers of newest folder can be used.

lottiegreenwood commented 7 years ago

Currently, the cycle number is found by looking at all the folders in the NDX[INSTRUMENT]/data and taking the last three numbers of the newest folder. It would be more robust to get the information directly from ICAT. If the REDUCTION Error about not being able to read the file still occurs, it might be a good idea to try with the cycle above/below before failing entirely.

lottiegreenwood commented 7 years ago

This should cover https://github.com/mantidproject/autoreduce/issues/128