Removed problem code - Githubissues

mantidproject / autoreduce

Autoreduction service

0 stars 0 forks source link

Removed problem code #332

Closed lottiegreenwood closed 7 years ago

lottiegreenwood commented 7 years ago

Fixes https://github.com/mantidproject/autoreduce/issues/325

tg137 commented 7 years ago

Just a couple of comments from me:

As far as I can tell, when re-running a single job, the option to "Reset to original script and values" no longer does anything. I don't know how widely used this was originally and if it wasn't ever used then we could just get rid of the option in the html as well as it seems that the deletion in this commit will remove this functionality.
I think we already mentioned that when you enter a description when re-running a single job, the information is not passed onto the next screen, nor is it stored in the database. It's worth mentioning here in case another issue needs to be created for it.

Everything else seems great to me. Changing the script will cause the values on the page to be updated where before they would have stayed at the default values.

Anders-Markvardsen commented 7 years ago

Rerun MARI 21839 with energy_bins changed from -1.5, 0.01, 0.9 to -1.5, 0.01, 0.8. Result: as stated above 'minor' bug that 'Description: No description provided' even though a description was provided, but more worrying it used energy_bin= -1.5, 0.01, 0.9. See MARI 21839 - 1
Again rerun MARI 21839 with energy_bins this time changed from -1.5, 0.01, 0.9 to -1.5, 0.01, 0.5. This time it has been run with the correct '-1.5, 0.01, 0.5'!! I am confused. See MARI 21839 - 2. I am wondering if I change energy_bin in the first rerun. Pressed 'Reset to original script and values' does do anything, confirming what Tom is seeing. However pressed 'Reset to current script and values' which does reset values to the current script values.

lottiegreenwood commented 7 years ago

@tg137 Re: >As far as I can tell, when re-running a single job, the option to "Reset to original script and values" no longer does anything. I was looking at removing the html, but I'm finding that if in a rerun (eg http://reduce.isis.cclrc.ac.uk/runs/36572/1/) change a variable, choose to reset it back to current variables, then click reset to original variables, it does change the number back and forth. I don't think this is very clear though, so probably worth thinking about how to improve the UI.