search

mantidproject / dockerfiles

Docker images relating to Mantid
https://hub.docker.com/u/mantidproject/
GNU General Public License v3.0
3 stars 7 forks source link

Merge static analysis image contents with development images #46

Closed martyngigg closed 3 years ago

martyngigg commented 3 years ago

Cppcheck is now taking along time to run and would benefit from access to more nodes.

These changes put the static analysis tools in the development image, also giving access to the same tools for developers, so that any node running that image can run the analysis.

Test

I have not yet pushed the images. I built Ubuntu locally and ran the cppcheck build script and it produced the expected number of warnings and HTML report. I would appreciate a second pair of eyes before pushing the new images.

DavidFair commented 3 years ago

Edit: Fixed, was a botched mount command

DavidFair commented 3 years ago

We need to include pre-commit into the images, at least for CentOS it's no pre-installed and prevents CMake finishing on the development image

martyngigg commented 3 years ago

We need to include pre-commit into the images, at least for CentOS it's no pre-installed and prevents CMake finishing on the development image

Thanks for the pre-commit reminder - I had forgotten we only included it in the Ubuntu ones. This will also gives us more nodes to be able to do that.