Closed DanNixon closed 5 years ago
I've pushed an updated set of images that include the sudo
changes.
@martyngigg That's odd, at that point everything should be running as the abc
user and groupmod
and usermod
should have already changed ownership of the home directory.
Edit: I don't get those errors.
Was this on a source build as I have not pushed updates to Docker Hub yet.
@DanNixon I thought that was odd too. I pulled the latest image from your account as mentioned in the original comment.
@martyngigg Ah, that may be it. I've pushed the latest versions now.
Thanks for pushing the updates. I don't appear to get the warnings any more.
One thing that just occurred to me that would make them slightly easier to use also would be if the data volume was mounted at $HOME/MantidExternalData
as it's the default if no -D
option is provided. It would then remove the need to specify -DMANTID_DATA_STORE=/mantid_data
on new cmake builds. Just a thought but not required.
@martyngigg Yes, that would be nicer, however it could drastically slow down the container start up time as usermod
(see entrypoint.sh
) will attempt to do a recursive owner change (currently it is only done for the directory itself) if the data directory was under $HOME
.
Given that there are already several parameters to specify I'm fine with having to specify this manually.
Ok.
Just out of interest, would a symbolic link work?
Possibly, not sure if usermod
would try to follow it or not.
The default of chown
is to dereference links so I'd assume it wouldn't make a difference (usermod
doesn't specify how links are handled).
I'll give it a try anyway.
Thanks. Shall I merge this and that can be a new PR? This is a good set of improvements already.
Yes, that's probably best.
Cheers
This does the following things:
USER
environment variable)src
andbuild
in more sensible lcoationsThis fixes:
To test: