mantidproject / mantid

Main repository for Mantid code
https://www.mantidproject.org
GNU General Public License v3.0
209 stars 122 forks source link

Inelastic Scripts Python3 conversion #19806

Closed louisemccann closed 5 years ago

louisemccann commented 7 years ago

This PR is for the conversion of Inelastic scripts to be python 3 compatible as part of issue #18550 Scripts covered are:

scripts/Inelastic/vesuvio/base.py
scripts/Inelastic/vesuvio/profiles.py
scripts/Inelastic/vesuvio/instrument.py
scripts/Inelastic/vesuvio/testing.py
scripts/Inelastic/vesuvio/fitting.py
scripts/Inelastic/vesuvio/backgrounds.py
scripts/Inelastic/vesuvio/commands.py
scripts/Inelastic/vesuvio/__init__.py
scripts/Inelastic/dos/load_helper.py
scripts/Inelastic/dos/load_phonon.py
scripts/Inelastic/dos/load_castep.py
scripts/Inelastic/dos/__init__.py
scripts/Inelastic/IndirectBayes.py
scripts/Inelastic/IndirectReductionCommon.py
scripts/Inelastic/IndirectCommon.py
scripts/Inelastic/IndirectMuscat.py
scripts/Inelastic/Direct/ISISDirecInelasticConfig.py
scripts/Inelastic/Direct/RunDescriptor.py
scripts/Inelastic/Direct/NonIDF_Properties.py
scripts/Inelastic/Direct/dgreduce.py
scripts/Inelastic/Direct/ReductionWrapper.py
scripts/Inelastic/Direct/PropertiesDescriptors.py
scripts/Inelastic/Direct/DirectEnergyConversion.py
scripts/Inelastic/Direct/diagnostics.py
scripts/Inelastic/Direct/__init__.py
scripts/Inelastic/Direct/ReductionHelpers.py
scripts/Inelastic/Direct/PropertyManager.py
scripts/Inelastic/Direct/CommonFunctions.py
scripts/Inelastic/IndirectNeutron.py
scripts/Inelastic/CrystalField/energies.py
scripts/Inelastic/CrystalField/fitting.py
scripts/Inelastic/CrystalField/normalisation.py
scripts/Inelastic/CrystalField/__init__.py
scripts/Inelastic/CrystalField/function.py
scripts/Inelastic/IndirectImport.py
martyngigg commented 5 years ago

python3-flake8 claims there are no issues here and we have test coverage for all of these places so I think this is done.