mantidproject / mantid

Main repository for Mantid code
https://www.mantidproject.org
GNU General Public License v3.0
211 stars 123 forks source link

Improve FindSXPeaks #20052

Closed AntonPiccardoSelg closed 7 years ago

AntonPiccardoSelg commented 7 years ago

SXPeaks currently finds the strongest peaks per spectrum and returns a peak list. The background calculation is based on data in the current spectrum. We want to:

In addition the algorithm does not handle WISH and ALF data. This needs to be fixed.

samueljackson92 commented 7 years ago

Reading about the problems uncovered with FindPeaksMD + the fact that ConvertToMD for one WISH file takes ~10mins suggests this a good idea.

It would be good to know how long it takes to search for peaks in each spectrum when you have as many as WISH. If this is very slow you could maybe cut down the search space by doing something like:

That may or may not be slower than a brute force search.

AntonPiccardoSelg commented 7 years ago

@samueljackson92 Thanks for commenting. I have training today, but I will be back on Monday. Let's talk about some of your suggestions then.