System tests pass on Ubuntu 20.04

mantidproject / mantid

Main repository for Mantid code

https://www.mantidproject.org

GNU General Public License v3.0

211 stars 123 forks source link

System tests pass on Ubuntu 20.04 #29362

Closed AndreiSavici closed 2 years ago

AndreiSavici commented 4 years ago

Part of #28650. Make sure all system tests pass on Ubuntu 20.04

[x] CalibrateRectangularDetector_Test.PG3Calibration
[x] CrystalFieldPythonInterface.CrystalFieldPythonInterface (fixed by installing required package)
[x] EnggCalibrationTest.EnginXCalibrateFullThenCalibrateTest
[x] PVPythonTest.PVPythonTest (fixed in #30036)
[x] VesuvioFittingTest.VesuvioFittingWithKFreeTest
[ ] SNSPowderRedux.PG3Analysis

AndreiSavici commented 4 years ago

FAILED:
CalibrateRectangularDetector_Test.PG3Calibration
CrystalFieldPythonInterface.CrystalFieldPythonInterface
EnggCalibrationTest.EnginXCalibrateFullThenCalibrateTest
PVPythonTest.PVPythonTest
VesuvioFittingTest.VesuvioFittingWithKFreeTest

98% tests passed, 5 tests failed out of 482 (24 skipped)

CalibrateRectangularDetector_Test.PG3Calibration - data mismatch
CrystalFieldPythonInterface.CrystalFieldPythonInterface failed because no pycifrw installed
EnggCalibrationTest.EnginXCalibrateFullThenCalibrateTes - wrong fitting result 2.24!=2.32
PVPythonTest.PVPythonTest - no paraview installed
VesuvioFittingTest.VesuvioFittingWithKFreeTest - data mismatch

martyngigg commented 3 years ago

CrystalFieldPythonInterface was failing because we had no PyCifRW build for 20.04. This is now in the mantid PPA so this should fix that test.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had activity in 6 months. It will be closed in 7 days if no further activity occurs. Allowing issues to close as stale helps us filter out issues which can wait for future development time. All issues closed by stale bot act like normal issues; they can be searched for, commented on or reopened at any point. If you'd like a closed stale issue to be considered, feel free to either re-open the issue directly or contact a developer. To extend the lifetime of an issue please comment below, it helps us see that this is still affecting you and you want it fixed in the near-future. Extending the lifetime of an issue may cause the development team to prioritise it over other issues, which may be closed as stale instead.

AndreiSavici commented 3 years ago

@peterfpeterson This is our internal issue https://code.ornl.gov/sns-hfir-scse/spectroscopy/spectroscopy/-/issues/44

martyngigg commented 2 years ago

As we're using Conda to support future Linux distribution then I think this issue is now no longer valid.