search

mantidproject / mantid

Main repository for Mantid code
https://www.mantidproject.org
GNU General Public License v3.0
210 stars 122 forks source link

Fit parameter tie should revert to previous value if not valid #31310

Closed thomashampson closed 1 year ago

thomashampson commented 3 years ago

In the plot fitting GUI, it is possible to set ties for parameters, e.g: image Once the tie has been created, the user can alter its value by editing the text in the value column.

Expected behavior

When altering the value of an existing tie by editing the text field, if it is not valid the value in the text box should revert back to the previous value.

Actual behavior

image The value entered into the text box remains even if it is invalid. This may catch out a user who mis-types and doesn't notice the warning message in the message log ("Failed to update tie on "). Possibly display a message box?

Steps to reproduce the behavior

Follow the steps in this tutorial to open the fitting GUI and create a tie for a parameter: https://docs.mantidproject.org/nightly/tutorials/mantid_basic_course/fitting_data/02_complex_case.html#complex-case Then change the value in the text box to something gibberish and press enter or leave the text box.

Platforms affected

Only tested on Windows so far.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had activity in 6 months. It will be closed in 7 days if no further activity occurs. Allowing issues to close as stale helps us filter out issues which can wait for future development time. All issues closed by stale bot act like normal issues; they can be searched for, commented on or reopened at any point. If you'd like a closed stale issue to be considered, feel free to either re-open the issue directly or contact a developer. To extend the lifetime of an issue please comment below, it helps us see that this is still affecting you and you want it fixed in the near-future. Extending the lifetime of an issue may cause the development team to prioritise it over other issues, which may be closed as stale instead.

stale[bot] commented 2 years ago

This issue has been closed automatically. If this still affects you please re-open this issue with a comment or contact us so we can look into resolving it.