search

mantidproject / mantid

Main repository for Mantid code
https://www.mantidproject.org
GNU General Public License v3.0
207 stars 121 forks source link

Units wrong in SaveSESANS algorithm #33983

Closed DannyHindson closed 1 year ago

DannyHindson commented 2 years ago

Original reporter: Rob Dalgliesh

Describe the bug This issue was raised via the Mantid help email with a request to open up a ticket to resolve this problem:

https://github.com/ISISNeutronMuon/mantid-isis-support/issues/33

The units of the values in the depolarisation column in the SaveSESANS algorithm aren't correct. The values need to be divided by the sample thickness. This will give values in of Å^-2 cm^-1 as indicated in the header

DannyHindson commented 2 years ago

@gemmaguest - is this issue one for your team? It came in last night on the Mantid support email from Rob (see linked issue). I've replied to him to indicate I'll raise a ticket

martyngigg commented 1 year ago

@rbauststfc Would you be able to look into this on Monday?

rbauststfc commented 1 year ago

@martyngigg , sure, that's no problem 🙂

DannyHindson commented 1 year ago

@rbauststfc - I meant to add this comment onto this issue yesterday but didn't get round to it. Seems like you've started work on this so wanted to flag this up. In my email conversation with Rob from back in May he had also requested a new parameter on the SaveSESANS algorithm called "Override Sample Thickness" or something similar:

Hi all,

Yes I’ll create a ticket to make these fixes to SaveSESANS. Just so I’m clear – is it the Depolarisation column that needs correcting? And you’d like a new parameter on the SaveSESANS algorithm that allows a user to supply an override thickness?

Thanks
Danny

This is on the linked support issue but wasn't highlighted on this issue. Only the calculation change to divide by sample thickness is mentioned here.

rbauststfc commented 1 year ago

@rbauststfc - I meant to add this comment onto this issue yesterday but didn't get round to it. Seems like you've started work on this so wanted to flag this up. In my email conversation with Rob from back in May he had also requested a new parameter on the SaveSESANS algorithm called "Override Sample Thickness" or something similar:

Hi all,

Yes I’ll create a ticket to make these fixes to SaveSESANS. Just so I’m clear – is it the Depolarisation column that needs correcting? And you’d like a new parameter on the SaveSESANS algorithm that allows a user to supply an override thickness?

Thanks
Danny

This is on the linked support issue but wasn't highlighted on this issue. Only the calculation change to divide by sample thickness is mentioned here.

Thanks for flagging @DannyHindson. I'd noticed that in the email chain, so I've included that in the changes I'm making.

mantid-builder commented 1 year ago

Fixed by #34491