Manual Testing FilterEvents

[sf1919]

You have been assigned manual testing. The hope is to catch as many problems with the code before release, so it would be great if you can take some time to give a serious test to your assigned area. Thank you!!

The general guide to manual testing:

• The tests must be performed on the installer versions of the final release candidate. Not on local compiled code.
• Serious errors involving loss of functionality, crashes etc. should be raised as issues with the current release as a milestone and an email sent to the project manager immediately.
• Minor and cosmetic issues should be raised as issues against the forthcoming releases.
• First try things that should work, then try to break Mantid, e.g. entering invalid values, unexpected characters etc.
• Don't spend more than a few hours on the testing as fatigue will kick in.
• If you find errors in the documentation, please correct them.
• Comment against this ticket the OS environment you are testing against.
• Close the this issue once you are done.

Specific Notes:

https://docs.mantidproject.org/interfaces/utility/Filter%20Events.html

[RichardWaiteSTFC]

Tested this with ARCS_23961_event.nxs (system test data). Have loaded, filtered events by time and log. I could not reproduce #24274 (max < min values for start/stop time and log value), and edit boxes only allow input of correct data type. Did find a couple of things:

• Errors are not caught (by the UI or in fact the underlying algorithm FilterEvents) - for example if you select a log but no min/max values then you get the following error from FilterEvents algorithm Invalid value for SplitterWorkspace: SplittersWorkspace must have rows defined

• Does not handle non-event data or data without expected log values. E.g. trying to load ENGINX00228061_log_alarm_data.nxs from @DanielMurphy22 results in

  Traceback (most recent call last):
  File "C:\MantidNightlyInstall\bin\lib\site-packages\mantidqtinterfaces\FilterEvents\eventFilterGUI.py", line 586, in load_File
  self._importDataWorkspace(dataws)
  File "C:\MantidNightlyInstall\bin\lib\site-packages\mantidqtinterfaces\FilterEvents\eventFilterGUI.py", line 708, in _importDataWorkspace
  errmsg = self._plotTimeCounts(dataws)
  File "C:\MantidNightlyInstall\bin\lib\site-packages\mantidqtinterfaces\FilterEvents\eventFilterGUI.py", line 841, in _plotTimeCounts
  last_pulse = wksp.getPulseTimeMax().toISO8601String()
  AttributeError: 'Workspace2D' object has no attribute 'getPulseTimeMax'

None of these are regressions and the UI does not to be an active area of development so closing issue