search

mantidproject / mantid

Main repository for Mantid code
https://www.mantidproject.org
GNU General Public License v3.0
207 stars 121 forks source link

Alter WavRangeReduction algorithm to take a Mantid workspace #35875

Open rbauststfc opened 11 months ago

rbauststfc commented 11 months ago

The SANS reduction algorithm, WavRangeReduction currently only takes a file name, it cannot take an already loaded Mantid workspace on which to perform the reduction. This extra flexibility would be extremely useful to support any bespoke pre-processing that's required for a reduction. At the moment the pre-processing would need to be done, the workspace saved out as a file and then the file name passed into WavRangeReduction. Loading SANS data takes a significant amount of time, so avoiding needing to do this twice in these circumstances would be very beneficial. We would need to consider how this can be done via the GUI, but it may be possible to use a similar approach to the NR GUI which, given a name to load, first checks if it's present in the ADS and if not then it is loaded from file.

This change will be required to support the SANS polarised reduction workflow #33638.

rbauststfc commented 8 months ago

At the moment the polarised SANS reduction scripts take a TOF workspace, convert it to wavelength, apply the relevant corrections and then convert the workspace back to TOF to pass into the normal SANS reduction algorithm. As part of this issue, we should confirm if it might be an option (both technically and scientifically) to just pass the workspace that's in wavelength to the SANS reduction algorithm.

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had activity in 6 months. It will be closed in 7 days if no further activity occurs. Allowing issues to close as stale helps us filter out issues which can wait for future development time. All issues closed by stale bot act like normal issues; they can be searched for, commented on or reopened at any point. If you'd like a closed stale issue to be considered, feel free to either re-open the issue directly or contact a developer. To extend the lifetime of an issue please comment below, it helps us see that this is still affecting you and you want it fixed in the near-future. Extending the lifetime of an issue may cause the development team to prioritise it over other issues, which may be closed as stale instead.