mantidproject / mantid

Main repository for Mantid code
https://www.mantidproject.org
GNU General Public License v3.0
208 stars 121 forks source link

Add unit tests to ISIS Energy Transfer presenter and data validator #35960

Open MohamedAlmaki opened 11 months ago

MohamedAlmaki commented 11 months ago

Blocked because parent class of presenter is a Qt object

Describe the outcome that is desired.

The ISIS Energy Transfer Tab has been refactored into the MVP pattern in this PR. Currently, the presenter ISISEnergyTransferPresenter.h and the data validator ISISEnergyTransferDataValidator.h have no unit tests. The goal of this issue is to add unit tests to the presenter and the data validator. Describe any solutions you are considering

The tests could be written using the CxxTest test suite like other unit tests in the project

Acceptance Criteria

MohamedAlmaki commented 7 months ago

This is blocked until the refactoring of all tabs is done. I've faced multiple issues when trying to mock QT objects

robertapplin commented 5 months ago

It looks like this might overlap with #36897