search

mantidproject / mantid

Main repository for Mantid code
https://www.mantidproject.org
GNU General Public License v3.0
211 stars 123 forks source link

System test to create algorithm dialogs #36127

Open robertapplin opened 1 year ago

robertapplin commented 1 year ago

Describe the bug We have recently seen the following stacktrace appear in the errorreporter several times:

Name: Not provided  Email: Not provided
        Additional text:
        Not provided
        Stack Trace:
        Traceback (most recent call last):
  File "/opt/conda/envs/mantid-singularity/lib/python3.8/site-packages/mantidqt/widgets/algorithmselector/widget.py", line 260, in execute_algorithm
    dialog = manager.createDialogFromName(algorithm.name, algorithm.version, None, False, presets, "", enabled)
Exception: unknown

It seems there is an unknown exception when creating some of our algorithm dialogs. It would be useful to have a system test which attempts to create our algorithm dialogs (but does not open them). We used to have a system test that did something similar, but it was refactored because it took a long time to run. It was refactored in this PR https://github.com/mantidproject/mantid/pull/35685

The new system test should not open the dialogs. This will hopefully mean the test will run quickly.

To Reproduce Create a system test which will create each of the algorithm dialogs and checks there is no exception. Run this system test until it fails (assuming it is an unreliable exception).

robertapplin commented 1 year ago

It is likely the exception is caused by providing a dodgy preset value for one of the properties

github-actions[bot] commented 5 months ago

This issue has been automatically marked as stale because it has not had activity in 6 months. It will be closed in 7 days if no further activity occurs. Allowing issues to close as stale helps us filter out issues which can wait for future development time. All issues closed by stale bot act like normal issues; they can be searched for, commented on or reopened at any point. If you'd like a closed stale issue to be considered, feel free to either re-open the issue directly or contact a developer. To extend the lifetime of an issue please comment below, it helps us see that this is still affecting you and you want it fixed in the near-future. Extending the lifetime of an issue may cause the development team to prioritise it over other issues, which may be closed as stale instead.

sf1919 commented 5 months ago

Not stale