There were some build warnings on linux about uninitialised values potentially being used. I think there wasn't actually any danger but I've initialised them anyway to stop the warnings, should be safer in the long run as well.
There is no associated issue.
To test:
Run ninja to build mantid. There should now only be warnings about setup.py being deprecated and nothing else
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Do changes function as described? Add comments below that describe the tests performed?
Do the changes handle unexpected situations, e.g. bad input?
Has the relevant (user and developer) documentation been added/updated?
Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.
Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.
Description of work
https://github.com/mantidproject/mantid/pull/37490 needs to be merged first.
There were some build warnings on linux about uninitialised values potentially being used. I think there wasn't actually any danger but I've initialised them anyway to stop the warnings, should be safer in the long run as well.
There is no associated issue.
To test:
ninjato build mantid. There should now only be warnings aboutsetup.pybeing deprecated and nothing elseReviewer
Please comment on the points listed below (full description). Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.