Add two new release notes to release 6.10

backmari commented 3 weeks ago

Description of work

Add to the 6.10 release notes two new release notes that have been added after the initial amalgamation.

Reviewer

Please comment on the points listed below (full description). Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

Is the code of an acceptable quality?
Does the code conform to the coding standards?
Are the unit tests small and test the class in isolation?
If there is GUI work does it follow the GUI standards?
If there are changes in the release notes then do they describe the changes appropriately?
Do the release notes conform to the release notes guide?

Functional Tests

Do changes function as described? Add comments below that describe the tests performed?
Do the changes handle unexpected situations, e.g. bad input?
Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

sf1919 commented 3 weeks ago

Does it also make sense to flag this GUI name change on the index page as part of the highlights - @robertapplin ?

backmari commented 3 weeks ago

@sf1919 @robertapplin There is this other name change release note in the same file. In that case we may want to combine them.

- The `Inelastic Data Analysis` interface has been renamed to the :ref:`Inelastic QENS Fitting <interface-inelastic-qens-fitting>` interface. The new name provides a better description of what it does.

robertapplin commented 3 weeks ago

@sf1919 @robertapplin There is this other name change release note in the same file. In that case we may want to combine them.

I think that sounds like a good idea, thank you both

robertapplin commented 3 weeks ago

Just to check @backmari , is the addition to the highlights something you would do as part of this PR, or a separate one?

backmari commented 3 weeks ago

@robertapplin I added the renaming highlight just now, please let me know if you spot something :slightly_smiling_face:

mantidproject / mantid