Fix issues in the boilerplate templates inside the class_maker tool that generate clang and cmake format issues.
Purpose of work
Make it easier to use the tool.
There is no associated issue.
To test:
Run python buildconfig/class_maker.py --alg Algorithms MyAlg
Commit the changes and verify that there are no pre-commit failures.
This does not require release notes because it's an update to a developer tool
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Do changes function as described? Add comments below that describe the tests performed?
Do the changes handle unexpected situations, e.g. bad input?
Has the relevant (user and developer) documentation been added/updated?
Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.
Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.
Description of work
Fix issues in the boilerplate templates inside the
class_makertool that generate clang and cmake format issues.Purpose of work
Make it easier to use the tool.
There is no associated issue.
To test:
python buildconfig/class_maker.py --alg Algorithms MyAlgThis does not require release notes because it's an update to a developer tool
Reviewer
Please comment on the points listed below (full description). Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.