This PR fixes an issue where the legacy validate() method was being called in the QENS Fitting interface when clicking Fit Single Spectrum. The solution was to call the validate() method in the new RunPresenter.
There is no associated issue.
To test:
Open Inelastic QENS Fitting
Click Fit Single Spectrum below the plots. A validation message should appear about missing data and fit function
Load some data
Click Fit Single Spectrum below the plots. A validation message should appear about missing fit function
Select a Fit function
Click Fit Single Spectrum below the plots. It should run successfully
This does not require release notes because it is a regression
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Do changes function as described? Add comments below that describe the tests performed?
Do the changes handle unexpected situations, e.g. bad input?
Has the relevant (user and developer) documentation been added/updated?
Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.
Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.
Description of work
This PR fixes an issue where the legacy
validate()
method was being called in the QENS Fitting interface when clickingFit Single Spectrum
. The solution was to call thevalidate()
method in the new RunPresenter.There is no associated issue.
To test:
Fit Single Spectrum
below the plots. A validation message should appear about missing data and fit functionFit Single Spectrum
below the plots. A validation message should appear about missing fit functionFit Single Spectrum
below the plots. It should run successfullyThis does not require release notes because it is a regression
Reviewer
Please comment on the points listed below (full description). Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.