There seems to be something wrong with the current file which is causing heap-breaking errors on macOS. I've created a new file from running the scripts in the documentation, and using that I don't get the same failures. This should improve the stability of the test.
Merging into release-next for the sake of the nightly pipelines.
Fixes #37499
Further detail of work
The test is functionally the same, changing where the spheres were just ensured that the test failed if it was still managing to use the old file.
To test:
Run the test multiple times.
Launch workbench and run this a few times in a script:
out = LoadNexusProcessed("SingleCrystalLeanElasticPeakTableNew.nxs")
This does not require release notes because only a test is changing.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Do changes function as described? Add comments below that describe the tests performed?
Do the changes handle unexpected situations, e.g. bad input?
Has the relevant (user and developer) documentation been added/updated?
Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.
Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.
Description of work
Summary of work
There seems to be something wrong with the current file which is causing heap-breaking errors on macOS. I've created a new file from running the scripts in the documentation, and using that I don't get the same failures. This should improve the stability of the test.
Merging into
release-nextfor the sake of the nightly pipelines.Fixes #37499
Further detail of work
To test:
This does not require release notes because only a test is changing.
Reviewer
Please comment on the points listed below (full description). Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.