Fix Issue 37040: Dragging text onto plot not handled well

yusufjimoh commented 3 months ago

Description of work

Dragging text onto the plot throws a KeyError.

Summary of work

Introduced error handling to gracefully handle the KeyError when dragging text onto the plot. Displays a warning to the user for invalid workspaces.

Fixes: https://github.com/mantidproject/mantid/issues/37040

To test:

Create a plot
Drag some text onto the plot
A warning is displayed to the user in the message box

Reviewer

Please comment on the points listed below (full description). Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

Is the code of an acceptable quality?
Does the code conform to the coding standards?
Are the unit tests small and test the class in isolation?
If there is GUI work does it follow the GUI standards?
If there are changes in the release notes then do they describe the changes appropriately?
Do the release notes conform to the release notes guide?

Functional Tests

Do changes function as described? Add comments below that describe the tests performed?
Do the changes handle unexpected situations, e.g. bad input?
Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

jhaigh0 commented 3 months ago

For commits like this https://github.com/mantidproject/mantid/pull/37524/commits/90b2f30924b5a61459498f4b5dcbe659fda25fe6 you are better off doing git commit --amend --no-edit which will just add the changes to your previous commit, remove he --no-edit if you want to change the commit name. If you have already pushed the changes, you'll have to do git push -f since you're changing the history

yusufjimoh commented 3 months ago

This will be very useful, I will add that to my git toolbox.

yusufjimoh commented 3 months ago

The latest commit contains the suggested necessary changes

added assert to the test function
ensure the try and except only wrap the concerned line of code.

mantidproject / mantid