Closed adriazalvarez closed 2 weeks ago
Thanks for your suggestions. It's a bit unfortunate there are other Iqt...
files. The changes look less homogeneous, but to avoid any confusion in the future I have preferred to keep it like this for the most parts, since it affects less code than changing the name of the Iqt tab on the data processor interface.
Description of work
After renaming the Data Analysis tab to QENS Fitting, we think the names of the tabs are a bit redundant (MSD Fit, I(Q,t) Fit, ConvFit...) as it is clear from the interface name that its purpose is to fit different types of data. The new names for the tabs are: MSD, I(Q,t), Convolution and Function(Q). In summary:
More information can be found in #36853.
Additionally, I have added a tooltip on the tabs, which will raise a helpful info message of what each tab does whenever the mouse is hovered on that tab.
To be noted: The
I(Q,t) Fit
is renamed asI(Q, t)
on the GUI, but the underlying classes and files preserve the name starting withIqtFit...
as there is a notherIqt..
class on the Data Processor interface that interferes with it, and it will raise confusion if both classes share the same name (for example there would be twoIqtModel
files).Fixes #36853 .
To test:
Inelastic QENS Fitting Manual Testing
instructions on the built docs, making sure the instructions contain the updated tab names.QENS Fitting
interface have the new names.Interfaces
->QENS Fitting
interface page and check everything looks updated with the new names and properly formatted.Added release notes
Reviewer
Please comment on the points listed below (full description). Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.