mantidproject / mantid

Main repository for Mantid code
https://www.mantidproject.org
GNU General Public License v3.0
207 stars 122 forks source link

Rename tabs of QENS Fitting interface #37532

Closed adriazalvarez closed 2 weeks ago

adriazalvarez commented 2 weeks ago

Description of work

After renaming the Data Analysis tab to QENS Fitting, we think the names of the tabs are a bit redundant (MSD Fit, I(Q,t) Fit, ConvFit...) as it is clear from the interface name that its purpose is to fit different types of data. The new names for the tabs are: MSD, I(Q,t), Convolution and Function(Q). In summary:

More information can be found in #36853.

Additionally, I have added a tooltip on the tabs, which will raise a helpful info message of what each tab does whenever the mouse is hovered on that tab.

To be noted: The I(Q,t) Fit is renamed as I(Q, t) on the GUI, but the underlying classes and files preserve the name starting with IqtFit... as there is a nother Iqt.. class on the Data Processor interface that interferes with it, and it will raise confusion if both classes share the same name (for example there would be two IqtModel files).

Fixes #36853 .

To test:

Added release notes


Reviewer

Please comment on the points listed below (full description). Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

Functional Tests

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

adriazalvarez commented 2 weeks ago

Thanks for your suggestions. It's a bit unfortunate there are other Iqt... files. The changes look less homogeneous, but to avoid any confusion in the future I have preferred to keep it like this for the most parts, since it affects less code than changing the name of the Iqt tab on the data processor interface.