See #37518 for full details, but conda-forge uses clang version 16, so this updates our version to match. Similarly for llvm_openmp.
Fixed a compiler warning in WideIntImpl.h due to an implicit cast.
Fixes #37518.
To test (macOS-only):
Remove your mantid-developer environment with conda env remove -n mantid-developer
Delete build/CMakeCache.txt
Create your mantid-developer environment with mamba env create -f mantid-developer-osx.yml
Check that your environment has the right version by running conda list | grep clang
Run cmake --preset=osx, the compiler version detected should be 16
Compile
Go and get a cup of tea
Everything should compile and run as normal
Check that the macOS CI build used version 16 instead of 15 by looking at the build logs, they'll need a clean build to pick up the compiler change (I'm waiting until after 6.10 is released before triggering those).
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Do changes function as described? Add comments below that describe the tests performed?
Do the changes handle unexpected situations, e.g. bad input?
Has the relevant (user and developer) documentation been added/updated?
Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.
Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.
See #37518 for full details, but
conda-forgeuses clang version 16, so this updates our version to match. Similarly forllvm_openmp.Fixed a compiler warning in
WideIntImpl.hdue to an implicit cast.Fixes #37518.
To test (macOS-only):
conda env remove -n mantid-developerbuild/CMakeCache.txtmamba env create -f mantid-developer-osx.ymlconda list | grep clangcmake --preset=osx, the compiler version detected should be 16Check that the macOS CI build used version 16 instead of 15 by looking at the build logs, they'll need a clean build to pick up the compiler change (I'm waiting until after 6.10 is released before triggering those).
Reviewer
Please comment on the points listed below (full description). Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.