Closed RichardWaiteSTFC closed 4 days ago
Whilst running the script, there were some typos which I fixed in #37615
Other than that, the script ran successfully. Also checked that altering the calc_absorption_weigthed_path_length() function made the unit test fail, so that's good.
Would it be possible to add another unit test like
test_process_data_with_scale_integrated
to check for the if statement you added in theprocess_data
function?
This if
statement actually caused the system test SXDAnalysis.SXDProcessSampleData
to fail, hence the need to specify scale_integrated=False
here
https://github.com/mantidproject/mantid/blob/6d2da87c679aade99d18ef0b1e2815d98247566c/Testing/SystemTests/tests/framework/SXDAnalysis.py#L95
but I can add another system test if you like?
Description of work
Adds a method to apply attenuation correction post-integration - this is how SXD like to apply the correction, in addition it is quicker than applying the correction to every bin in the raw workspace.
Fixes #37235
To test:
(1) Run through script in docs
Reviewer
Please comment on the points listed below (full description). Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.